Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prometheus): Removing prometheus recording rule metrics #3211

Merged
merged 3 commits into from
Sep 18, 2023
Merged

feat(prometheus): Removing prometheus recording rule metrics #3211

merged 3 commits into from
Sep 18, 2023

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented Aug 14, 2023 •
edited
Loading

Removing prometheus recording rule metrics

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated

@github-actions github-actions bot added the documentation documentation label Aug 14, 2023
@rnishtala-sumo rnishtala-sumo marked this pull request as ready for review August 14, 2023 18:54
@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner August 14, 2023 18:54
@rnishtala-sumo rnishtala-sumo changed the title feat(prometheus): Removing prometheus recording rules feat(prometheus): Removing prometheus recording rule metrics Aug 14, 2023
swiatekm
swiatekm reviewed Aug 16, 2023
View reviewed changes
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from one note. We should also create the v4 migration doc and have this PR add a note about recording rule removal there.

deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
swiatekm
swiatekm reviewed Aug 17, 2023
View reviewed changes
deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
@rnishtala-sumo rnishtala-sumo force-pushed the drop-recording-rules branch 7 times, most recently from 50e3707 to f2fb913 Compare August 17, 2023 21:21
swiatekm
swiatekm reviewed Aug 18, 2023
View reviewed changes
docs/v4-migration-doc.md Outdated Show resolved Hide resolved
@swiatekm swiatekm added this to the v4.0 milestone Aug 18, 2023
swiatekm
swiatekm approved these changes Aug 18, 2023
View reviewed changes
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions[bot]
github-actions bot requested changes Aug 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

@sumo-drosiek sumo-drosiek mentioned this pull request Sep 6, 2023
Closed
4 tasks
@swiatekm swiatekm force-pushed the drop-recording-rules branch from e87dfe0 to 55b6356 Compare September 18, 2023 15:26
@swiatekm swiatekm force-pushed the drop-recording-rules branch from 55b6356 to 56debcd Compare September 18, 2023 15:38
@swiatekm swiatekm merged commit 203bef9 into main Sep 18, 2023
33 checks passed
@swiatekm swiatekm deleted the drop-recording-rules branch September 18, 2023 15:49
@swiatekm swiatekm mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
documentation documentation integration-tests
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rnishtala-sumo @swiatekm